lkml.org 
[lkml]   [2015]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2] net: ll_temac: Use one return statement instead of two
    From
    Date
    On Mon, 2015-05-11 at 17:26 +0200, Michal Simek wrote:
    > On 05/11/2015 04:42 PM, Joe Perches wrote:
    > > On Mon, 2015-05-11 at 16:05 +0200, Michal Simek wrote:
    > >> Use one return statement instead of two to simplify the code.
    > >> Both are returning the same value.
    > >
    > > trivia and FYI:
    >
    > But still correct right?

    Yes.

    > > I think there are about 100 of these in kernel tree
    > > and I'm not going to submit patches.
    > >
    > > $ grep-2.5.4 -rP --include=*.[ch] -n "^([\t]+)\treturn[ \t]+([A-Za-z0-9\_\>\(\)\.\>\[\]\-]+);\n(\1}\n)?\1return[ \t]+\2;" * | \
    > > grep -P "^[\w\/\.]+:\d+:"
    >
    > Are you suggesting that someone else should send patches for it?

    I get enough grief for doing style oriented patches,
    so if someone else wants to, sure.

    > I expect that this is something what Julia can check with coccinelle
    > and can be added to scripts folder.

    Maybe true.

    A coccinelle script might be rather more complicated
    than the simpler grep above, but perhaps the script
    could be a bit more complete as it could likely look
    at more code indentation styles.




    \
     
     \ /
      Last update: 2015-05-11 18:21    [W:5.034 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site