lkml.org 
[lkml]   [2015]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] net: phy: micrel: Fix regression in kszphy_probe
On Mon, May 11, 2015 at 05:21:06PM +0200, Niklas Cassel wrote:
> Don't do clock-mode-select if clk == NULL,
> since when building without CONFIG_HAVE_CLK,
> clk_get returns NULL and clk_get_rate returns 0.
>
> Doing clock-mode-select in this cause causes kszphy_probe to
> return -EINVAL and thus prevents the device from being probed.
>
> The original code (before regression) would return 0
> when building without CONFIG_HAVE_CLK.
>
> Cc: stable <stable@vger.kernel.org> # 3.18+
> 1fadee0c3645 ("net/phy: micrel: Add clock support for
> KSZ8021/KSZ8031")

Looks like you forgot the "Fixes: " tag itself when updating.

> Signed-off-by: Niklas Cassel <niklass@axis.com>

Look good otherwise, feel free to add my

Reviewed-by: Johan Hovold <johan@kernel.org>

when resending (unless David wants to fix it up himself).

Thanks,
Johan


\
 
 \ /
  Last update: 2015-05-11 18:21    [W:0.037 / U:17.648 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site