lkml.org 
[lkml]   [2015]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] perf report: Do not restrict -T option by other options
Hi Arnaldo,

On Sun, May 10, 2015 at 02:20:59PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, May 10, 2015 at 12:19:44AM +0900, Namhyung Kim escreveu:
> > It seems there's no reason to suppress per-thread event stat by -T
> > option when -s or -p option is used. Make it work with those options.
>
> Not applying on my perf/core branch, please check, I'll push what I have
> now.

It seems that it's because the commit e944ec2ca00f ("perf report: Fix
-T/--threads option to work again") in the perf/urgent is not merged
to the perf/core yet.

I'll resend v2 soon.

Thanks,
Namhyung


>
> - Arnaldo
>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > ---
> > tools/perf/builtin-report.c | 13 ++++++-------
> > 1 file changed, 6 insertions(+), 7 deletions(-)
> >
> > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> > index ee541ad555f2..0ae5eaaaf766 100644
> > --- a/tools/perf/builtin-report.c
> > +++ b/tools/perf/builtin-report.c
> > @@ -330,15 +330,14 @@ static int perf_evlist__tty_browse_hists(struct perf_evlist *evlist,
> > }
> >
> > if (sort_order == NULL &&
> > - parent_pattern == default_parent_pattern) {
> > + parent_pattern == default_parent_pattern)
> > fprintf(stdout, "#\n# (%s)\n#\n", help);
> >
> > - if (rep->show_threads) {
> > - bool style = !strcmp(rep->pretty_printing_style, "raw");
> > - perf_read_values_display(stdout, &rep->show_threads_values,
> > - style);
> > - perf_read_values_destroy(&rep->show_threads_values);
> > - }
> > + if (rep->show_threads) {
> > + bool style = !strcmp(rep->pretty_printing_style, "raw");
> > + perf_read_values_display(stdout, &rep->show_threads_values,
> > + style);
> > + perf_read_values_destroy(&rep->show_threads_values);
> > }
> >
> > return 0;
> > --
> > 2.3.7


\
 
 \ /
  Last update: 2015-05-11 16:01    [W:0.090 / U:4.008 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site