lkml.org 
[lkml]   [2015]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] genirq: Set IRQCHIP_SKIP_SET_WAKE flag for dummy_irq_chip
From
On Wed, Apr 15, 2015 at 10:14 AM, Roger Quadros <rogerq@ti.com> wrote:
> Without this system suspend is broken on systems that have
> drivers calling enable/disable_irq_wake() for interrupts based off
> the dummy irq hook.

Good to see this was applied. Still, I think no_irq_chip should also be
fixed, cfr. my patch "genirq: Set IRQCHIP_SKIP_SET_WAKE for no_irq_chip and
dummy_irq_chip" (https://lkml.org/lkml/2015/1/12/506 is down, but
https://patchwork.ozlabs.org/patch/427788/ works)

> (e.g. drivers/gpio/gpio-pcf857x.c)

Please note the particular pfc857x.c case was fixed by commit b80eef95beb04760
("gpio: pcf857x: Propagate wake-up setting to parent irq controller"), as that
driver has other problems. Now it no longer uses dummy_irq_chip.

> http://article.gmane.org/gmane.linux.kernel/1879035
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> kernel/irq/dummychip.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/irq/dummychip.c b/kernel/irq/dummychip.c
> index 988dc58..2feb6fe 100644
> --- a/kernel/irq/dummychip.c
> +++ b/kernel/irq/dummychip.c
> @@ -57,5 +57,6 @@ struct irq_chip dummy_irq_chip = {
> .irq_ack = noop,
> .irq_mask = noop,
> .irq_unmask = noop,
> + .flags = IRQCHIP_SKIP_SET_WAKE,
> };
> EXPORT_SYMBOL_GPL(dummy_irq_chip);
> --
> 2.1.0


Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2015-05-11 13:01    [W:0.099 / U:24.224 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site