Messages in this thread | | | Date | Mon, 11 May 2015 15:56:07 +0600 | Subject | Re: [PATCH 0/2] x86/earlyprintk: setup earlyprintk as early as possible | From | Alexander Kuleshov <> |
| |
Hello Andy,
Thank you for feedback. Will fix and resend.
2015-05-11 13:27 GMT+06:00 Andy Shevchenko <andriy.shevchenko@linux.intel.com>: > On Mon, 2015-05-11 at 01:13 +0600, Alexander Kuleshov wrote: >> As setup_early_printk passed to the early_param, it will be usable only after >> 'parse_early_param' function will be called from the 'setup_arch'. So we have >> earlyprintk during early boot and decompression. Next point after decompression >> of the kernel where we can use early_printk is after call of the >> 'parse_early_param'. > > From this description is hard to understand what is rationale of the > proposed changes. Can you rephrase it? > >> >> These patchset provides two patches where: >> >> 1. Move handling of the builtin command line to the separate function >> from the setup_arch. Now we can call it from the arch/x86/kernel/head{32,64}.c, >> and find 'earlyprintk' kernel command line paramter there. >> >> 2. Provide setup_serial_console function to setup serial earlyprintk in the >> arch/x86/kernel/head{32,64}.c >> >> Alexander Kuleshov (2): >> x86/setup: update boot_command_line with builtin_cmdline in separate >> function >> x86/earlyprintk: setup earlyprintk as early as possible >> >> arch/x86/include/asm/serial.h | 2 ++ >> arch/x86/include/asm/setup.h | 3 ++- >> arch/x86/kernel/early_printk.c | 25 +++++++++++++++++++++++++ >> arch/x86/kernel/head32.c | 6 ++++++ >> arch/x86/kernel/head64.c | 7 +++++++ >> arch/x86/kernel/setup.c | 28 +++++++++++++++------------- >> 6 files changed, 57 insertions(+), 14 deletions(-) >> > > > -- > Andy Shevchenko <andriy.shevchenko@intel.com> > Intel Finland Oy >
-- _________________________ 0xAX
| |