lkml.org 
[lkml]   [2015]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for EHCI drv
Date


> -----Original Message-----
> From: Alan Stern [mailto:stern@rowland.harvard.edu]
> Sent: Friday, May 08, 2015 7:56 PM
> To: Mehresh Ramneek-B31383
> Cc: linux-kernel@vger.kernel.org; balbi@ti.com; linux-usb@vger.kernel.org;
> gregkh@linuxfoundation.org
> Subject: RE: [PATCH 02/10] drivers:host:fsl: Use ehci_overrides structure for
> EHCI drv
>
> On Fri, 8 May 2015, Ramneek Mehresh wrote:
>
> > > On Thu, 7 May 2015, Ramneek Mehresh wrote:
> > >
> > > > Make use of ehci_driver_overrides structure for ehci-fsl driver
> > > >
> > > > Signed-off-by: Ramneek Mehresh
> <ramneek.mehresh@freescale.com>
> > >
> > > You need to change a lot more than this. See commit a76dd463c58e
> (USB:
> > > EHCI: make ehci-orion a separate driver) as an example of what is
> > > needed. In the end, ehci-fsl.ko should be a new driver module, not
> > > compiled into ehci- hcd.ko.
> > >
> > I can definitely make this change, but this patch set is about OTG
> > functionality fix for all FSL QorIQ socs. Changes you are asking are
> > for FSL Host driver. For that I can float separate patch/patch set.
> > Hence, I would request you to please accept the Patch series in conext
> > of OTG functionality fix
>
> Accept which patch series? You have posted several different versions (and
> you failed to put the version numbers in the email Subject:
> lines, so I can't tell which patches belong to which version!).
>
> I am not going to accept something that does a partial job of converting ehci-
> fsl into a separate module. Either do the entire conversion first, as a
> separate patch that is prerequisite to the OTG fix, or else fix the OTG stuff in
> a way that doesn't require ehci-fsl to be a separate module.
>
Ok, then let me first fix USB host driver as per expectation...
I'll then re-send OTG patch set over that...I don't want to intermingle these two
separate functionalities. Thanks.

> Alan Stern



\
 
 \ /
  Last update: 2015-05-11 07:21    [W:0.043 / U:20.512 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site