Messages in this thread | | | Date | Mon, 11 May 2015 10:47:44 +0200 | From | Daniel Lezcano <> | Subject | Re: [PATCH 03/12] clocksource: sti: Provide 'use timer as sched clock' capability |
| |
On 05/08/2015 01:47 PM, Paul Bolle wrote: > On Fri, 2015-05-08 at 11:29 +0100, Lee Jones wrote: >> Ah, you mean from menuconfig. I almost forgot what that was. ;) >> >> I can add a menu option, no problem. > > It's not just menuconfig: > $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config > CONFIG_ARCH_STI=y > CONFIG_CLKSRC_ST_LPC=y > CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK=y > $ vim .config > $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config > CONFIG_ARCH_STI=y > # CONFIG_CLKSRC_ST_LPC is not set > # CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK is not set > $ make ARCH=arm silentoldconfig > scripts/kconfig/conf --silentoldconfig Kconfig > # > # configuration written to .config > # > $ grep -e CONFIG_ARCH_STI -e CONFIG_CLKSRC_ST_LPC .config > CONFIG_ARCH_STI=y > CONFIG_CLKSRC_ST_LPC=y > CONFIG_CLKSRC_ST_LPC_TIMER_SCHED_CLOCK=y > > So I think that, if you want to be able to set > CLKSRC_ST_LPC_TIMER_SCHED_CLOCK to 'n' even though CLKSRC_ST_LPC is 'y', > you need to add a prompt. Or have you found a way around this?
The general policy is to have non-prompted options in the clocksource's Kconfig and let the platform's config to select the right components.
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |