[lkml]   [2015]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 2/4] PM / Hibernate: prepare for SANITIZE_FREED_PAGES
Hi Pavel,

Thanks a lot for taking the time to review this.

On Sat, May 9, 2015 at 5:44 PM, Pavel Machek <> wrote:
>> + clear_free_pages();
>> + printk(KERN_INFO "PM: free pages cleared after restore\n");
>> +#endif
>> + }
>> platform_leave(platform_mode);
>> Power_up:
> Can you move the ifdef and the printk into the clear_free_pages?

Sure. I put the printk out originally because i thought there might be
other uses, but since this is the sole call site right now it
shouldn't be an issue.

> This is not performance critical in any way...
> Otherwise it looks good to me... if the sanitization is considered
> useful. Did it catch some bugs in the past?

I've read somewhere that users of grsecurity claim that it caught bugs
in some drivers, but I haven't verified that personally; it's probably
much less useful than kasan (or even the original grsec feature) as a
bug-catcher since it doesn't clear freed slab buffers.

I'll wait a few more days for more reviews before sending the next
version, particularly on the power management part, and in general on
the usefulness of such feature.



 \ /
  Last update: 2015-05-11 10:41    [W:0.083 / U:43.432 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site