lkml.org 
[lkml]   [2015]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V4 net-next 1/1] hv_netvsc: Use the xmit_more skb flag to optimize signaling the host
Date


> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Sunday, May 10, 2015 2:51 PM
> To: KY Srinivasan
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> jasowang@redhat.com
> Subject: Re: [PATCH V4 net-next 1/1] hv_netvsc: Use the xmit_more skb flag
> to optimize signaling the host
>
> From: "K. Y. Srinivasan" <kys@microsoft.com>
> Date: Wed, 6 May 2015 15:29:05 -0700
>
> > - ret = vmbus_sendpacket_pagebuffer(out_channel,
> > - pgbuf,
> > - packet->page_buf_cnt,
> > - &nvmsg,
> > - sizeof(struct
> nvsp_message),
> > - req_id);
> > + ret = vmbus_sendpacket_pagebuffer_ctl(out_channel,
> > + pgbuf,
> > + packet->page_buf_cnt,
> > + &nvmsg,
> > + sizeof(struct
> > + nvsp_message),
> > + req_id,
> > + vmbus_flags,
> > + !packet->xmit_more);
> > } else {
> > - ret = vmbus_sendpacket(
> > + ret = vmbus_sendpacket_ctl(
> > out_channel, &nvmsg,
> > sizeof(struct nvsp_message),
> > req_id,
> > VM_PKT_DATA_INBAND,
> > -
> VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED);
> > + vmbus_flags, !packet->xmit_more);
>
> Just as you did for the vmbus_sendpacket_pagebuffer_ctl() call above,
> you'll need to reindent the arguments for the vmbus_sendpacket_ctl()
> call since the openning parenthesis is now at a different column.

Done.

Regards,

K. Y
>
> Thanks.


\
 
 \ /
  Last update: 2015-05-11 05:01    [W:0.136 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site