lkml.org 
[lkml]   [2015]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 10/20] staging: lustre: lov: lov_dev: remove unneeded null test before free
    Date
    Kfree can cope with a null argument, so drop null tests.

    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @@ expression ptr; @@

    - if (ptr != NULL)
    kfree(ptr);
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    drivers/staging/lustre/lustre/lov/lov_dev.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/staging/lustre/lustre/lov/lov_dev.c b/drivers/staging/lustre/lustre/lov/lov_dev.c
    index 63db87a..504b24a 100644
    --- a/drivers/staging/lustre/lustre/lov/lov_dev.c
    +++ b/drivers/staging/lustre/lustre/lov/lov_dev.c
    @@ -298,8 +298,7 @@ static struct lu_device *lov_device_free(const struct lu_env *env,
    const int nr = ld->ld_target_nr;

    cl_device_fini(lu2cl_dev(d));
    - if (ld->ld_target != NULL)
    - kfree(ld->ld_target);
    + kfree(ld->ld_target);
    if (ld->ld_emrg != NULL)
    lov_emerg_free(ld->ld_emrg, nr);
    kfree(ld);


    \
     
     \ /
      Last update: 2015-05-01 22:21    [W:4.124 / U:0.748 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site