Messages in this thread | | | From | Pali Rohár <> | Subject | Re: [PATCH] Input: atkbd: Fix release quirk for Dell models | Date | Thu, 9 Apr 2015 19:00:50 +0200 |
| |
On Thursday 09 April 2015 18:57:19 Dmitry Torokhov wrote: > On Wed, Apr 08, 2015 at 10:54:20PM +0200, Pali Rohár wrote: > > On Monday 06 April 2015 18:20:56 Dmitry Torokhov wrote: > > > On Mon, Apr 06, 2015 at 10:06:10AM +0200, Pali Rohár wrote: > > > > > > > > > Ah, indeed. Sorry, at this time I completely forgot that > > > we are controlling this from userspace nowadays. > > > > > > > > > > > > > > > > > > No, this is not a kernel regression because it would mean > > > that your laptop worked properly with then current kernel > > > and then stopped working. Given that the change went in > > > in 2008 and your laptop is a bit newer than that you > > > can't claim kernel regression here; as far as I can see > > > the change was reasonable for the lineage we had back > > > then, or at least noone notified us for about 6 years. > > > > > > > > > > > > So please do adjust udev rules, there are quite a bit for > > > tweaks for Dell and other manufacturer's laptop keyboards > > > there). > > > > > > > > > > > > Thanks. > > > > > > > > Ok, thanks for information. Maybe you can add some comment > > to source code or documentation, that this part of code is > > now handled by userspace. So other people send patches to > > correct place/projects in future. > > Fair enough. How about below? > > Thanks. > > -- > Dmitry > > Input: atkbd - document "no new force-release quirks" policy > > From: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > To save people some time let's document that we do not want > new quirks for "force-release" keys in the kernel and that > they should patch userspace (udev) instead. > > Suggested-by: Pali Rohár <pali.rohar@gmail.com> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > ---
Looks good for me.
-- Pali Rohár pali.rohar@gmail.com [unhandled content-type:application/pgp-signature] | |