lkml.org 
[lkml]   [2015]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers: CCI: fix used_mask init in validate_group()
> > > > >  validate_group(struct perf_event *event)
> > > > > {
> > > > > struct perf_event *sibling, *leader = event->group_leader;
> > > > > - struct cci_pmu_hw_events fake_pmu = {
> > > > > - /*
> > > > > - * Initialise the fake PMU. We only need to populate the
> > > > > - * used_mask for the purposes of validation.
> > > > > - */
> > > > > - .used_mask = CPU_BITS_NONE,
> > > >
> > > > Can we not simply change this to:
> > > >
> > > > .used_mask = { 0 },
> > > >
> > > > That should result in the entire array being zeroed.
> > >
> > > It does, but it also causes the whole struct to be cleared.
> >
> > Sure, but it's also the minimal diff, and it's easier to read. This was
> > what the code was intended to be initially.
> >
> > > With the memset, only used_mask gets cleared.
> >
> > Is there an appreciable difference between the two performance-wise?
>
> I dunno. It is 3 strp insns vs 1 str.
> If you want the static init, I'll send another patch.

I'd prefer the designated initializer to the memset.

Thanks,
Mark.


\
 
 \ /
  Last update: 2015-04-09 17:21    [W:0.098 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site