lkml.org 
[lkml]   [2015]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] iio: adc: ti_am335x_adc: refactor DT parsing into a function
On 31/03/15 12:12, Vignesh R wrote:
> Refactor DT parsing into a separate function from probe() to
> help addition of more DT parameters later.
>
> No functional changes.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
Clearly going to need this whatever the outcome of the second patch being
reviewed.

Applied to the togreg branch of iio.git - initially pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan
> ---
> drivers/iio/adc/ti_am335x_adc.c | 29 +++++++++++++++++++----------
> 1 file changed, 19 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
> index 2e5cc4409f78..2f818405ffbe 100644
> --- a/drivers/iio/adc/ti_am335x_adc.c
> +++ b/drivers/iio/adc/ti_am335x_adc.c
> @@ -396,16 +396,30 @@ static const struct iio_info tiadc_info = {
> .driver_module = THIS_MODULE,
> };
>
> +static int tiadc_parse_dt(struct platform_device *pdev,
> + struct tiadc_device *adc_dev)
> +{
> + struct device_node *node = pdev->dev.of_node;
> + struct property *prop;
> + const __be32 *cur;
> + int channels = 0;
> + u32 val;
> +
> + of_property_for_each_u32(node, "ti,adc-channels", prop, cur, val) {
> + adc_dev->channel_line[channels] = val;
> + channels++;
> + }
> +
> + adc_dev->channels = channels;
> + return 0;
> +}
> +
> static int tiadc_probe(struct platform_device *pdev)
> {
> struct iio_dev *indio_dev;
> struct tiadc_device *adc_dev;
> struct device_node *node = pdev->dev.of_node;
> - struct property *prop;
> - const __be32 *cur;
> int err;
> - u32 val;
> - int channels = 0;
>
> if (!node) {
> dev_err(&pdev->dev, "Could not find valid DT data.\n");
> @@ -421,12 +435,7 @@ static int tiadc_probe(struct platform_device *pdev)
> adc_dev = iio_priv(indio_dev);
>
> adc_dev->mfd_tscadc = ti_tscadc_dev_get(pdev);
> -
> - of_property_for_each_u32(node, "ti,adc-channels", prop, cur, val) {
> - adc_dev->channel_line[channels] = val;
> - channels++;
> - }
> - adc_dev->channels = channels;
> + tiadc_parse_dt(pdev, adc_dev);
>
> indio_dev->dev.parent = &pdev->dev;
> indio_dev->name = dev_name(&pdev->dev);
>



\
 
 \ /
  Last update: 2015-04-09 16:41    [W:0.107 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site