lkml.org 
[lkml]   [2015]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/8] iio: accel: mma9553: check input value for activity period
On 08/04/15 15:37, Irina Tirdea wrote:
> When setting the activity period, the value introduced by
> the user in sysfs is not checked for validity.
>
> Add a boundary check so that only allowed values are
> reported as suuccesfully written to device.
>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> Suggested-by: Hartmut Knaack <knaack.h@gmx.de>
Good point. This one counts as a fix so put it early in the
reordered series.
> ---
> drivers/iio/accel/mma9553.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c
> index 57868fb..96e4708 100644
> --- a/drivers/iio/accel/mma9553.c
> +++ b/drivers/iio/accel/mma9553.c
> @@ -839,6 +839,9 @@ static int mma9553_write_event_value(struct iio_dev *indio_dev,
> case IIO_EV_INFO_PERIOD:
> switch (chan->type) {
> case IIO_ACTIVITY:
> + if (val < 0 || val > MMA9553_ACTIVITY_THD_TO_SEC(
> + MMA9553_MAX_ACTTHD))
> + return -EINVAL;
> mutex_lock(&data->mutex);
> ret = mma9553_set_config(data, MMA9553_REG_CONF_ACTTHD,
> &data->conf.actthd,
>



\
 
 \ /
  Last update: 2015-04-09 14:21    [W:0.119 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site