lkml.org 
[lkml]   [2015]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/8] iio: accel: mma9553: fix gpio bitnum init value
On 08/04/15 15:37, Irina Tirdea wrote:
> Initial value of gpio bitnum is set to -1, but
> the variable is declared as unsigned.
>
> Use a positive invalid value for initial gpio
> bitnum.
>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> Suggested-by: Hartmut Knaack <knaack.h@gmx.de>
This is fine, but I'm feeling lazy as this isn't going
anywhere until after the merge window now. Will pick it
up once you've done the reordering to pull the fixes to the
top of the series.

J
> ---
> drivers/iio/accel/mma9553.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c
> index 9cfedb5..d781999 100644
> --- a/drivers/iio/accel/mma9553.c
> +++ b/drivers/iio/accel/mma9553.c
> @@ -78,6 +78,7 @@
>
> /* Bitnum used for GPIO configuration = bit number in high status byte */
> #define MMA9553_STATUS_TO_BITNUM(bit) (ffs(bit) - 9)
> +#define MMA9553_MAX_BITNUM MMA9553_STATUS_TO_BITNUM(BIT(16))
>
> #define MMA9553_DEFAULT_SAMPLE_RATE 30 /* Hz */
>
> @@ -406,8 +407,8 @@ static int mma9553_init(struct mma9553_data *data)
> }
>
>
> - data->gpio_bitnum = -1;
> /* Reset GPIO */
> + data->gpio_bitnum = MMA9553_MAX_BITNUM;
> ret = mma9553_conf_gpio(data);
> if (ret < 0)
> return ret;
>



\
 
 \ /
  Last update: 2015-04-09 14:21    [W:0.115 / U:1.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site