Messages in this thread |  | | Date | Thu, 9 Apr 2015 13:29:43 +0200 | From | Pavel Machek <> | Subject | Re: [PATCHv7] media: i2c/adp1653: Devicetree support for adp1653 |
| |
On Thu 2015-04-09 11:10:17, Sebastian Reichel wrote: > Hi, > > On Thu, Apr 09, 2015 at 09:42:38AM +0200, Pavel Machek wrote: > > [...] > > +#include <linux/of_gpio.h> > > +#include <linux/gpio.h> > > [...] > > This should probably be > > #include <linux/of.h> > #include <linux/gpio/consumer.h>
And I thought people would only bikesched paint on the Documentation. Sakari, feel free to change that, but a) I don't see why Sebastian's version is better and b) am pretty sure there is about infinite number of possibilities there.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
|  |