lkml.org 
[lkml]   [2015]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.4 065/176] storvsc: ring buffer failures may result in I/O freeze
    Date
    From: Long Li <longli@microsoft.com>

    3.4.107-rc1 review patch. If anyone has any objections, please let me know.

    ------------------


    commit e86fb5e8ab95f10ec5f2e9430119d5d35020c951 upstream.

    When ring buffer returns an error indicating retry, storvsc may not
    return a proper error code to SCSI when bounce buffer is not used.
    This has introduced I/O freeze on RAID running atop storvsc devices.
    This patch fixes it by always returning a proper error code.

    Signed-off-by: Long Li <longli@microsoft.com>
    Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Zefan Li <lizefan@huawei.com>
    ---
    drivers/scsi/storvsc_drv.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
    index 446c023..a0df0fb 100644
    --- a/drivers/scsi/storvsc_drv.c
    +++ b/drivers/scsi/storvsc_drv.c
    @@ -1359,13 +1359,12 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
    if (ret == -EAGAIN) {
    /* no more space */

    - if (cmd_request->bounce_sgl_count) {
    + if (cmd_request->bounce_sgl_count)
    destroy_bounce_buffer(cmd_request->bounce_sgl,
    cmd_request->bounce_sgl_count);

    - ret = SCSI_MLQUEUE_DEVICE_BUSY;
    - goto queue_error;
    - }
    + ret = SCSI_MLQUEUE_DEVICE_BUSY;
    + goto queue_error;
    }

    return 0;
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-04-09 12:21    [W:2.126 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site