lkml.org 
[lkml]   [2015]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.4 081/176] ALSA: hda - Fix wrong gpio_dir & gpio_mask hint setups for IDT/STAC codecs
    Date
    From: Takashi Iwai <tiwai@suse.de>

    3.4.107-rc1 review patch. If anyone has any objections, please let me know.

    ------------------


    commit c507de88f6a336bd7296c9ec0073b2d4af8b4f5e upstream.

    stac_store_hints() does utterly wrong for masking the values for
    gpio_dir and gpio_data, likely due to copy&paste errors. Fortunately,
    this feature is used very rarely, so the impact must be really small.

    Reported-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Zefan Li <lizefan@huawei.com>
    ---
    sound/pci/hda/patch_sigmatel.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
    index 137b67f..606f87a 100644
    --- a/sound/pci/hda/patch_sigmatel.c
    +++ b/sound/pci/hda/patch_sigmatel.c
    @@ -4246,9 +4246,9 @@ static void stac_store_hints(struct hda_codec *codec)
    spec->gpio_mask;
    }
    if (get_int_hint(codec, "gpio_dir", &spec->gpio_dir))
    - spec->gpio_mask &= spec->gpio_mask;
    - if (get_int_hint(codec, "gpio_data", &spec->gpio_data))
    spec->gpio_dir &= spec->gpio_mask;
    + if (get_int_hint(codec, "gpio_data", &spec->gpio_data))
    + spec->gpio_data &= spec->gpio_mask;
    if (get_int_hint(codec, "eapd_mask", &spec->eapd_mask))
    spec->eapd_mask &= spec->gpio_mask;
    if (get_int_hint(codec, "gpio_mute", &spec->gpio_mute))
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-04-09 12:21    [W:3.603 / U:0.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site