Messages in this thread |  | | Subject | Re: [PATCH V1 1/2] input: misc: da9063: OnKey driver | From | Paul Bolle <> | Date | Thu, 09 Apr 2015 10:47:53 +0200 |
| |
A license mismatch was all I spotted.
On Wed, 2015-04-08 at 15:53 +0100, Steve Twiss wrote: > From: Steve Twiss <stwiss.opensource@diasemi.com> > > Add OnKey driver support for DA9063 > > This patch is dependent on PATCH V1 2/2
(But I also spotted this line. And then I checked 2/2, which has: This patch is dependent on PATCH V1 1/2
Which makes it all rather confusing.
Anyhow, neither patch should need to carry such a line. The 1/2 and 2/2 in the Subject: line should suffice.)
> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com> > > --- > This patch applies against linux-next and v4.0-rc6
> --- /dev/null > +++ b/drivers/input/misc/da9063-onkey.c > @@ -0,0 +1,227 @@ > +/* da9063-onkey.c - Onkey device driver for DA9063 > + * Copyright (C) 2013 Dialog Semiconductor Ltd. > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Library General Public > + * License as published by the Free Software Foundation; either > + * version 2 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Library General Public License for more details. > + */
This states the license is GPL v2 or later.
> +MODULE_LICENSE("GPL v2");
And (according to include/linux/module.h) this states the license is (just) GPL v2.
Paul Bolle
|  |