lkml.org 
[lkml]   [2015]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2 2/6] i2c: qup: Add V2 tags support
Date
Hi Andy,

> -----Original Message-----
> From: linux-arm-kernel [mailto:linux-arm-kernel-
> bounces@lists.infradead.org] On Behalf Of Andy Gross
> Sent: Tuesday, April 07, 2015 10:37 AM
> To: Sricharan R
> Cc: srichara@qti.qualcomm.com; devicetree@vger.kernel.org; linux-arm-
> msm@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> i2c@vger.kernel.org; iivanov@mm-sol.com; galak@codeaurora.org;
> dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V2 2/6] i2c: qup: Add V2 tags support
>
> On Tue, Apr 07, 2015 at 12:01:03AM +0530, Sricharan R wrote:
>
> <snip>
>
> > +static u32 qup_i2c_send_data(struct qup_i2c_dev *qup, int tlen, u8
*tbuf,
> > + int dlen, u8 *dbuf)
> > +{
> > + u32 val = 0, idx = 0, pos = 0, i = 0, t;
> > + int len = tlen + dlen;
> > + u8 *buf = tbuf;
> > +
> > + while (len > 0) {
> > + if (qup_i2c_wait_ready(qup, QUP_OUT_FULL, 0, 4)) {
>
> Instead of 0 and 4 can we use some #defines? This applies for all of the
> i2c_wait_ready calls
>
> <snip>
>
Ok, will change this with some macro.

Regards,
Sricharan

>
> --
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum, a Linux Foundation Collaborative Project
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



\
 
 \ /
  Last update: 2015-04-08 08:01    [W:0.048 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site