lkml.org 
[lkml]   [2015]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/2] nohz: make nohz_full imply isolcpus
    On Mon, Apr 06, 2015 at 02:16:45PM -0400, cmetcalf@ezchip.com wrote:
    > From: Chris Metcalf <cmetcalf@ezchip.com>
    >
    > It's not clear that nohz_full is useful without isolcpus also
    > set, since otherwise the scheduler has to run periodically to
    > try to determine whether to steal work from other cores.
    >
    > Signed-off-by: Chris Metcalf <cmetcalf@ezchip.com>
    > Acked-by: Mike Galbraith <umgwanakikbuti@gmail.com> ["thumbs up!"]
    > Acked-by: Rik van Riel <riel@redhat.com>

    Peter, are you ok with that change? I think that you planned to remove
    cpu_isolated_map a while ago, so I prefer to wait for your ack.

    Thanks.

    > ---
    > kernel/sched/core.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
    > index f0f831e8a345..275f12c608f2 100644
    > --- a/kernel/sched/core.c
    > +++ b/kernel/sched/core.c
    > @@ -6836,6 +6836,7 @@ static int init_sched_domains(const struct cpumask *cpu_map)
    > doms_cur = alloc_sched_domains(ndoms_cur);
    > if (!doms_cur)
    > doms_cur = &fallback_doms;
    > + tick_nohz_full_set_cpus(cpu_isolated_map);
    > cpumask_andnot(doms_cur[0], cpu_map, cpu_isolated_map);
    > err = build_sched_domains(doms_cur[0], NULL);
    > register_sched_domain_sysctl();
    > --
    > 2.1.2
    >


    \
     
     \ /
      Last update: 2015-04-08 01:01    [W:3.614 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site