lkml.org 
[lkml]   [2015]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 3/4] cgroups: allow a cgroup subsystem to reject a fork
On Tue, Apr 07, 2015 at 11:47:02PM +1000, Aleksa Sarai wrote:
> > [...] I don't
> > think it's a good idea to send the patches as-are because we can't
> > debug and fix them properly, right? [...]
>
> In what way are they hard to debug?

Some failures can happen before console init and figuring out what's
going on can be tricky.

...
> difference between having an array of CGROUP_SUBSYS_COUNT pointers or
> CGROUP_PREFORK_COUNT is the few bytes of memory you've "saved" (at the expense
> of making the callback code essentially unreadable).

Hmmm? Just define a marker macro so that the index can be extracted
and loop over the indices and call the callbacks? Why would this be
any more complex than anything else?

--
tejun


\
 
 \ /
  Last update: 2015-04-07 16:41    [W:0.048 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site