Messages in this thread | | | Date | Tue, 7 Apr 2015 08:52:46 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 00/18 v3] tracing: Use TRACE_DEFINE_ENUM() to show enum values |
| |
On Tue, 07 Apr 2015 20:26:29 +0900 Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> I've reviewed all patches in this series and tested it. > > Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > Tested-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > > for all the patches in this series.
Thanks for spending the time on this. I'll be hopefully posting this to linux-next when it finally passes all my tests (I've been finding use cases that need to be fixed for this to work). The code itself is still sound.
> > However, I've also found that the __print_symbolic()s in > > events/scsi/scsi_dispatch_cmd_*/format > events/xfs/xfs_map_blocks_alloc/format > events/xfs/xfs_get_blocks_found/format > events/xfs/xfs_get_blocks_alloc/format > events/power/pm_qos_*/format
Ah, missed some of those, as scsi and xfs use mostly defines, not enums. I need to boot a config that has all tracepoints enabled and check them out.
Thanks,
-- Steve
> > are not fixed yet. > > Thank you, > > > > > -- Steve
| |