lkml.org 
[lkml]   [2015]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] perf evlist: Fix inverted logic in perf_mmap__empty
    Em Tue, Apr 07, 2015 at 05:31:10PM +0800, He Kuang escreveu:
    > perf_evlist__mmap_consume() uses perf_mmap__empty() to judge whether
    > perf_mmap is empty and can be released. But the result is inverted so
    > fix it.

    > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
    > @@ -695,7 +695,7 @@ union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx)
    >
    > static bool perf_mmap__empty(struct perf_mmap *md)
    > {
    > - return perf_mmap__read_head(md) != md->prev;
    > + return perf_mmap__read_head(md) == md->prev;
    > }
    >
    > static void perf_evlist__mmap_get(struct perf_evlist *evlist, int idx)

    Argh, thanks, good spotting, applying...

    - Arnaldo


    \
     
     \ /
      Last update: 2015-04-07 14:41    [W:2.629 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site