Messages in this thread | | | Date | Tue, 7 Apr 2015 11:27:08 +0200 | From | Quentin Casasnovas <> | Subject | Re: [PATCH] x86/alternatives: Fix ALTERNATIVE_2 padding generation properly |
| |
On Sat, Apr 04, 2015 at 03:34:43PM +0200, Borislav Petkov wrote: > From: Borislav Petkov <bp@suse.de> > > Quentin caught a corner case with the generation of instruction padding > in the ALTERNATIVE_2 macro: if len(orig_insn) < len(alt1) < len(alt2), > then not enough padding gets added and that is not good(tm) as we could > overwrite the beginning of the next instruction. >
FWIW, this patch looks good to me (I have not tested it though).
Thanks!
Quentin
| |