Messages in this thread | | | Date | Wed, 08 Apr 2015 11:36:33 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH -tip] perf probe: fix ARM 32 building error. |
| |
(2015/04/08 11:14), Wang Nan wrote: > Commit 9b118acae310f57baee770b5db402500d8695e50 ("perf probe: Fix to > handle aliased symbols in glibc") uses an absolute format '%lx' to > print u64 argument, which causes compiling error on ARM 32. > > This patch replaces it with PRIx64.
Good catch! :)
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thanks!
> > Signed-off-by: Wang Nan <wangnan0@huawei.com> > --- > tools/perf/util/probe-event.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 8feac07..3dacec9 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -320,7 +320,8 @@ static int find_alternative_probe_point(struct debuginfo *dinfo, > ret = -ENOENT; > goto out; > } > - pr_debug("Symbol %s address found : %lx\n", pp->function, address); > + pr_debug("Symbol %s address found : %" PRIx64 "\n", > + pp->function, address); > > ret = debuginfo__find_probe_point(dinfo, (unsigned long)address, > result); >
-- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com
| |