lkml.org 
[lkml]   [2015]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.13.y-ckt 065/156] cpuset: Fix cpuset sched_relax_domain_level
    Date
    3.13.11-ckt19 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jason Low <jason.low2@hp.com>

    commit 283cb41f426b723a0255702b761b0fc5d1b53a81 upstream.

    The cpuset.sched_relax_domain_level can control how far we do
    immediate load balancing on a system. However, it was found on recent
    kernels that echo'ing a value into cpuset.sched_relax_domain_level
    did not reduce any immediate load balancing.

    The reason this occurred was because the update_domain_attr_tree() traversal
    did not update for the "top_cpuset". This resulted in nothing being changed
    when modifying the sched_relax_domain_level parameter.

    This patch is able to address that problem by having update_domain_attr_tree()
    allow updates for the root in the cpuset traversal.

    Fixes: fc560a26acce ("cpuset: replace cpuset->stack_list with cpuset_for_each_descendant_pre()")
    Signed-off-by: Jason Low <jason.low2@hp.com>
    Signed-off-by: Zefan Li <lizefan@huawei.com>
    Signed-off-by: Tejun Heo <tj@kernel.org>
    Tested-by: Serge Hallyn <serge.hallyn@canonical.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    kernel/cpuset.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/kernel/cpuset.c b/kernel/cpuset.c
    index 0b29c52..3344e70 100644
    --- a/kernel/cpuset.c
    +++ b/kernel/cpuset.c
    @@ -508,9 +508,6 @@ static void update_domain_attr_tree(struct sched_domain_attr *dattr,

    rcu_read_lock();
    cpuset_for_each_descendant_pre(cp, pos_css, root_cs) {
    - if (cp == root_cs)
    - continue;
    -
    /* skip the whole subtree if @cp doesn't have any CPU */
    if (cpumask_empty(cp->cpus_allowed)) {
    pos_css = css_rightmost_descendant(pos_css);
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-04-08 01:41    [W:4.107 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site