Messages in this thread | | | Date | Mon, 06 Apr 2015 16:36:29 -0400 (EDT) | Subject | Re: [PATCH] mvneta: dont call mvneta_adjust_link() manually | From | David Miller <> |
| |
From: Stas Sergeev <stsp@list.ru> Date: Wed, 01 Apr 2015 19:23:29 +0300
> > mvneta_adjust_link() is a callback for of_phy_connect() and should > not be called directly. The result of calling it directly is as below: > --- > mvneta f1030000.ethernet eth1: Link is Up - Unsupported (update p > hy.c)/Half - flow control off > --- > > This is because initially the struct phy_device is created with > invalid parameters. phylib calls adjust_link() only when the parameters > are validated, but calling it by hands may happen too early. > > CC: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > CC: netdev@vger.kernel.org > CC: linux-kernel@vger.kernel.org > CC: Florian Fainelli <f.fainelli@gmail.com> > > Signed-off-by: Stas Sergeev <stsp@users.sourceforge.net>
Applied, thanks.
| |