Messages in this thread | | | Date | Mon, 6 Apr 2015 17:26:57 +0200 | Subject | Re: [PATCH 2/3] of: OF_IRQ should depend on IRQ_DOMAIN | From | Geert Uytterhoeven <> |
| |
Hi Arnd,
On Mon, Apr 6, 2015 at 4:40 PM, Arnd Bergmann <arnd@arndb.de> wrote: >> --- a/drivers/of/Kconfig >> +++ b/drivers/of/Kconfig >> @@ -50,7 +50,7 @@ config OF_ADDRESS_PCI >> >> config OF_IRQ >> def_bool y >> - depends on !SPARC >> + depends on !SPARC && IRQ_DOMAIN >> >> config OF_NET >> depends on NETDEVICES >> > > Sparc does not set IRQ_DOMAIN, so we can probably simplify this to > > config OF_IRQ > def_bool IRQ_DOMAIN > > unless you want to keep the sparc antidependency explicit.
Given drivers/base/platform.c:
int platform_get_irq(struct platform_device *dev, unsigned int num) { #ifdef CONFIG_SPARC ... #else struct resource *r; if (IS_ENABLED(CONFIG_OF_IRQ) && dev->dev.of_node) { ... } ... #endif }
yes I do want to keep it explicit.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |