Messages in this thread | | | Date | Mon, 6 Apr 2015 07:50:48 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/6] block: export blkdev_reread_part() |
| |
On Mon, Apr 06, 2015 at 12:40:12AM +0800, Ming Lei wrote: > > int blkdev_reread_part(struct block_device *bdev) > > { > > if (!mutex_trylock(&bdev->bd_mutex)) > > return -EBUSY; > > blkdev_reread_part_nolock(bdev); > > mutex_unlock(&bdev->bd_mutex); > > } > > Yes, it is more clean, but with extra acquiring lock cost for the > failure cases, especially when we replace trylock with mutex_lock().
It's just a few fairly trivial checks, so 'm not really worried about it, especially given that blkdev_reread_part isn't called from a fast path.
| |