Messages in this thread Patch in this message | | | From | Giedrius Statkevicius <> | Subject | [PATCH 3/3] staging: dgnc: improve the coding style in unlocking part of dgnc_tty_write() | Date | Mon, 6 Apr 2015 00:15:55 +0300 |
| |
do
if (blah) foo(); bar();
instead of
if (blah) { foo(); bar(); } else { bar(); }
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@gmail.com> --- drivers/staging/dgnc/dgnc_tty.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index 651a925..c59a784 100644 --- a/drivers/staging/dgnc/dgnc_tty.c +++ b/drivers/staging/dgnc/dgnc_tty.c @@ -1843,12 +1843,10 @@ static int dgnc_tty_write(struct tty_struct *tty, ch->ch_cpstime += (HZ * count) / ch->ch_digi.digi_maxcps; } - if (from_user) { - spin_unlock_irqrestore(&ch->ch_lock, flags); + if (from_user) mutex_unlock(&dgnc_TmpWriteSem); - } else { - spin_unlock_irqrestore(&ch->ch_lock, flags); - } + + spin_unlock_irqrestore(&ch->ch_lock, flags); if (count) { /* -- 2.3.5
| |