Messages in this thread | | | Date | Sat, 04 Apr 2015 19:59:19 +0300 | From | Alexey Khoroshilov <> | Subject | Re: [PATCH] [media] marvell-ccic: fix memory leak on failure path in cafe_smbus_setup() |
| |
On 04.04.2015 16:36, Jonathan Corbet wrote: > On Sat, 4 Apr 2015 03:16:01 +0300 > Alexey Khoroshilov <khoroshilov@ispras.ru> wrote: > >> If i2c_add_adapter() fails, adap is not deallocated. >> >> Found by Linux Driver Verification project (linuxtesting.org). >> >> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> > > Actually, the worse thing is that it leaves the IRQ enabled...it's good > you moved that lines down. Even better, of course, that the failure path > has probably never been run during the life of this driver...:)
And hopefully it will not, but we will be ready:)
> > Should there be some sort of proper reported-by line for the driver > verification project?
Till now, we used "Found by" line, but we are open to any better way.
> > Acked-by: Jonathan Corbet <corbet@lwn.net>
-- Alexey
| |