Messages in this thread | | | Date | Sat, 4 Apr 2015 22:36:22 +0100 | From | Al Viro <> | Subject | Re: [PATCH 02/16] vfs: check kiocb->ki_flags instead filp->fl_flags |
| |
On Sat, Apr 04, 2015 at 11:13:11PM +0400, Dmitry Monakhov wrote: > generic_write_checks now accept kiocb as an argument > Unfortunetly it is impossible to get rid of old interface because some crappy > do not support write_iter interface so leave __generic_write_checks as backward > compatibility helper.
Check the current vfs.git#for-next (there's even some generic_write_checks() work in it). The same goes for the rest of the series. Please, rebase it.
What's more, generic_write_checks() should take iov_iter *, not the address of something its ->count had been copied into. Note that all callers of that thing end up doing iov_iter_truncate() pretty soon afterwards. I hadn't pushed that one out yet (there is some weirdness in ocfs2 which might be a bug; I want to sort that out first), but that's where it's going.
| |