Messages in this thread Patch in this message | | | Date | Thu, 30 Apr 2015 14:53:46 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 06/13] mm: meminit: Inline some helper functions |
| |
On Tue, 28 Apr 2015 15:37:03 +0100 Mel Gorman <mgorman@suse.de> wrote:
> early_pfn_in_nid() and meminit_pfn_in_nid() are small functions that are > unnecessarily visible outside memory initialisation. As well as unnecessary > visibility, it's unnecessary function call overhead when initialising pages. > This patch moves the helpers inline.
mm/page_alloc.c: In function 'memmap_init_zone': mm/page_alloc.c:4287: error: implicit declaration of function 'early_pfn_in_nid'
--- a/mm/page_alloc.c~mm-meminit-inline-some-helper-functions-fix +++ a/mm/page_alloc.c @@ -950,8 +950,16 @@ static inline bool __meminit early_pfn_i { return meminit_pfn_in_nid(pfn, node, &early_pfnnid_cache); } + +#else + +static inline bool __meminit early_pfn_in_nid(unsigned long pfn, int node) +{ + return true; +} #endif + #ifdef CONFIG_CMA /* Free whole pageblock and set its migration type to MIGRATE_CMA. */ void __init init_cma_reserved_pageblock(struct page *page)
allmodconfig. It's odd that nobody else hit this...
| |