lkml.org 
[lkml]   [2015]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/4] clk: si5351: Do not pass struct clk in platform_data
From
Hi Sebastian,

On Thu, Apr 30, 2015 at 3:44 PM, Sebastian Hesselbarth
<sebastian.hesselbarth@gmail.com> wrote:

> Fabio,
>
> Michael is right, the check is for bailing out if none of the parent
> clocks is available.

+ if (IS_ERR(drvdata->pxtal) && IS_ERR(drvdata->pclkin)) {
+ dev_err(&client->dev, "missing at least one parent clock\n");
+ return -EINVAL;
+ }

Then shouldn't the error message be: "missing both parent clocks\n" ?

Regards,

Fabio Estevam


\
 
 \ /
  Last update: 2015-04-30 21:41    [W:0.100 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site