Messages in this thread | | | Date | Thu, 30 Apr 2015 16:16:40 -0300 | Subject | Re: [PATCH 3/4] clk: si5351: Do not pass struct clk in platform_data | From | Fabio Estevam <> |
| |
Hi Sebastian,
On Thu, Apr 30, 2015 at 3:44 PM, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:
> Fabio, > > Michael is right, the check is for bailing out if none of the parent > clocks is available.
+ if (IS_ERR(drvdata->pxtal) && IS_ERR(drvdata->pclkin)) { + dev_err(&client->dev, "missing at least one parent clock\n"); + return -EINVAL; + }
Then shouldn't the error message be: "missing both parent clocks\n" ?
Regards,
Fabio Estevam
| |