Messages in this thread | | | Date | Thu, 30 Apr 2015 19:37:35 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 0/3] Introduce SET_NOIRQ_SYSTEM_SLEEP_PM_OPS and use it |
| |
On Mon 2015-04-27 21:24:29, grygorii.strashko@linaro.org wrote: > From: Grygorii Strashko <grygorii.strashko@linaro.org> > > While working on suspend-to-disk functionality on TI dra7-evm (DRA7xx SoC) > i've found that the most common problem I have to dial with is absence > of corresponding PM callbacks in drivers and, in particular, noirq callbacks. > So, I've fixed one driver first > commit 6248015d6867 "ARM: omap-device: add missed callback for suspend-to-disk" > but then found another one which need to be fixed too (omap_l3_noc.c). > At this moment I decided to make my life easier and added new macro > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS using the same approach as for the existing > SET_SYSTEM_SLEEP_PM_OPS macro. > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS: defined for CONFIG_PM_SLEEP and > assigns ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same > function. Vice versa happens for ->resume_noirq, ->thaw_noirq and > ->restore_noirq. > > Further two patches reuse this newly introduced macro. > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, defined for CONFIG_PM_SLEEP, will > point ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same > function. Vice versa happens for ->resume_noirq, ->thaw_noirq and > ->restore_noirq. > > Cc: Tony Lindgren <tony@atomide.com> > Cc: Nishanth Menon <nm@ti.com> > Cc: Kevin Hilman <khilman@linaro.org> > Cc: Santosh Shilimkar <ssantosh@kernel.org>
Looks ok to me.
Acked-by: Pavel Machek <pavel@ucw.cz>
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |