lkml.org 
[lkml]   [2015]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev
On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote:
>
>
> On April 3, 2015 5:19:55 AM EDT, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> >> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct
> >net_device *dev)
> >> IEEE_SOFTMAC_TX_QUEUE)) ||
> >> ((!ieee->softmac_data_hard_start_xmit &&
> >> (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
> >> - printk(KERN_WARNING "%s: No xmit handler.\n",
> >> + netdev_info(ieee->dev, "%s: No xmit handler.\n",
> >
> >
> >This should be netdev_warn(). There are a few other similar places.
> >
> >regards,
> >dan carpenter
> My bad will send in a v2 fixing this.

Please don't, I'm not going to be taking patches from you any _year_
soon.

sorry,

greg k-h


\
 
 \ /
  Last update: 2015-04-03 19:41    [W:1.085 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site