Messages in this thread | | | Date | Fri, 03 Apr 2015 13:00:28 +0300 | From | Stas Sergeev <> | Subject | Re: [PATCH] mvneta: implement SGMII-based in-band link state signaling |
| |
03.04.2015 03:51, David Miller пишет: > From: Stas Sergeev <stsp@list.ru> > Date: Tue, 31 Mar 2015 16:24:59 +0300 > >> @@ -2590,6 +2651,7 @@ static int mvneta_mdio_probe(struct mvneta_port *pp) >> >> static void mvneta_mdio_remove(struct mvneta_port *pp) >> { >> + fixed_phy_set_link_update(pp->phy_dev, NULL); > > I do not see any other driver doing this on shutdown. > Please show me why it is necessary. Hello David, sorry for this being discussed in a different thread, so here you have a few pointers to why is this needed: https://lkml.org/lkml/2015/3/30/367
> And if it is, all other drivers registering a fixed phy link update > function need to be adjusted to do the same thing. Or, for example, get rid of the callback and add an API: http://www.spinics.net/lists/netdev/msg323517.html
Then you get the patch that avoids all this call-back singing and dancing: http://www.spinics.net/lists/netdev/msg323518.html
In any case, I posted 3 different implementations and hope people will choose the best one (any choice is fine with me).
| |