lkml.org 
[lkml]   [2015]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv3 08/11] usb: dwc3: add hsphy_interface property
> > +	/* Select the HS PHY interface */
> > + switch (DWC3_GHWPARAMS3_HSPHY_IFC(dwc->hwparams.hwparams3)) {
> > + case DWC3_GHWPARAMS3_HSPHY_IFC_UTMI_ULPI:
> > + if (!strncmp(dwc->hsphy_interface, "utmi", 4)) {
> > + reg &= ~DWC3_GUSB2PHYCFG_ULPI_UTMI;
> > + } else if (!strncmp(dwc->hsphy_interface, "ulpi", 4)) {
> > + reg |= DWC3_GUSB2PHYCFG_ULPI_UTMI;
> > + } else {
> > + dev_err(dwc->dev, "HSPHY Interface not defined\n");
> > + return -EINVAL;
>
> instead of erroring out, just leave default value and convert this to a
> dev_warn() or something similar. That way, older DTS will continue to
> work.

OK, I'll change it.

Thanks,

--
heikki


\
 
 \ /
  Last update: 2015-04-29 10:21    [W:1.796 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site