lkml.org 
[lkml]   [2015]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 03/23] gpio: sysfs: drop redundant lock-as-irq
    From
    On Tue, Apr 21, 2015 at 5:42 PM, Johan Hovold <johan@kernel.org> wrote:

    > Drop redundant lock-as-irq in gpio_setup_irq, which has already been
    > handled when requesting and releasing the irq (i.e. in the irq chip
    > irq_request_resources and irq_release_resources callbacks).

    Well we would hope they all do that. And I hope for the vast majority
    that is true, but there is a TODO to go over all gpiochip drivers
    (some which are elsewhere in the kernel than drivers/gpio) and
    make sure they actually do so.

    Right now it's a bit arbitrary if so happens, and in not marked by
    the driver as IRQ then this kicks in and provides an additional
    protection.

    But maybe that's overzealous, what do people say?

    Yours,
    Linus Walleij


    \
     
     \ /
      Last update: 2015-04-30 00:21    [W:4.072 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site