Messages in this thread | | | Date | Wed, 29 Apr 2015 15:47:54 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf tools: Fix bison-related build failure on CentOS 6 |
| |
Em Wed, Apr 29, 2015 at 08:14:14PM +0200, Jiri Olsa escreveu: > On Wed, Apr 29, 2015 at 07:57:05PM +0200, Jiri Olsa wrote: > > On Wed, Apr 29, 2015 at 01:27:40PM -0300, Arnaldo Carvalho de Melo wrote: > > > > The YYLTYPE_IS_TRIVIAL is defined in the Build file, but unlike > > > > pmu-bison.c, gcc complained about it for parse-events-bison.c: > > > > > > > > CC util/parse-events-bison.o > > > > In file included from util/parse-events.y:16: > > > > util/parse-events-bison.h:101:1: error: "YYLTYPE_IS_TRIVIAL" redefined > > > > <command-line>: error: this is the location of the previous definition > > > > make[3]: *** [util/parse-events-bison.o] Error 1 > > > > > > > > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > > > > > > Ok, so this helps, it builds now on RHEL6.6, which was something I and > > > Jiri were chasing, but why has it complained for one and not the other? > > > Ideas? > > > > looks like the RHEL6 gcc/cpp treats this as an error which > > is not maskable by '-w' option > > > > anyway I checked the git log history and I'm not sure > > why we event have this define, it was added by Ingo > > and carried by ever since: > > > > 65f3e56e0c81 perf tools: Remove auto-generated bison/flex files > > > > probably because of the fail I see if I remove it from pmu-bison.o build: > > > > util/pmu-bison.c:613:6: error: "YYLTYPE_IS_TRIVIAL" is not defined > > ok, seem's the patch is right and the reason is the > parse error handling that was added just recently > > it adds YYLTYPE type (which is not present in pmu-bison.h), > so YYLTYPE_IS_TRIVIAL gets redefined, which is ok in F20 > that handle the error via '-w' option, but it's not ok for RHEL6 > where the '-w' does not work for this kind of error
Ok, adding this comment to the changelog, together with your Acked-by, ok?
- Arnaldo
| |