Messages in this thread | | | Date | Tue, 28 Apr 2015 15:34:25 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v2] spi: omap2-mcspi: Add support for GPIO chipselects |
| |
On Mon, Apr 27, 2015 at 08:21:50PM -0500, Michael Welling wrote:
> Before I send another patch how does this look?
> if (gpio_is_valid(spi->cs_gpio)) { > if (cs_active) > gpio_set_value(spi->cs_gpio, spi->mode & SPI_CS_HIGH); > else > gpio_set_value(spi->cs_gpio, !(spi->mode & SPI_CS_HIGH)); > }
That's good but please have braces around the inner if for clarity.
> If I were to attempt to convert the driver to use the core chipselect support, > how would I go about doing it?
> Is there another driver that I can use for reference?
Martin and Ezequiel already gave you some good examples - in general anything providing the set_cs() operation should be reasonable to look at. [unhandled content-type:application/pgp-signature] | |