Messages in this thread | | | Date | Mon, 27 Apr 2015 22:57:09 -0400 (EDT) | Subject | Re: [PATCH net 1/1] hv_netvsc: Fix a bug in netvsc_start_xmit() | From | David Miller <> |
| |
From: "K. Y. Srinivasan" <kys@microsoft.com> Date: Mon, 27 Apr 2015 18:14:50 -0700
> Commit commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory > allocation in the packet send path. This commit introduced a bug since it > did not account for the case if the skb was cloned. Fix this bug by > using the pre-reserved head room only if the skb is not cloned. > > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
We have generic infrastructure to do this, please try instead:
err = skb_cow_head(skb, pkt_sz);
this will take care of everything for you and you can get rid of all of this dynamic memory allocation etc. in this code path.
| |