Messages in this thread | | | Date | Tue, 28 Apr 2015 01:23:07 +0300 | From | Stas Sergeev <> | Subject | Re: [PATCH v2 0/3] leds: blink resolution improvements |
| |
27.04.2015 23:54, Pavel Machek пишет: > Hi! > >> The following patches improve the precision of led >> timer trigger and add the delay unit control. >> That allows to make PWM brightness control with timer >> trigger. > Are you sure that is good idea? Doing LED pwm with main cpu is quite harsh... > > We already have "brightness" for... well... brightness level. Btw, your concern can also be addressed in a simple way: just remove the "brightness" attribute in "timer" mode if the HW does not support brightness. In some modes you still need brightness to write either 0 or 255, but in timer mode it seems absolutely redundant without a HW implementation. I'd like to create the patch to conditionally disable the brightness attr in "timer" mode, but I wonder if the change will have the unexpected compatibility problems...
| |