lkml.org 
[lkml]   [2015]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/3] leds: blink resolution improvements
27.04.2015 23:54, Pavel Machek пишет:
> Hi!
>
>> The following patches improve the precision of led
>> timer trigger and add the delay unit control.
>> That allows to make PWM brightness control with timer
>> trigger.
> Are you sure that is good idea? Doing LED pwm with main cpu is quite harsh...
>
> We already have "brightness" for... well... brightness level.
Btw, your concern can also be addressed in a simple way:
just remove the "brightness" attribute in "timer" mode if the
HW does not support brightness. In some modes you still
need brightness to write either 0 or 255, but in timer mode
it seems absolutely redundant without a HW implementation.
I'd like to create the patch to conditionally disable the
brightness attr in "timer" mode, but I wonder if the change
will have the unexpected compatibility problems...


\
 
 \ /
  Last update: 2015-04-28 01:01    [W:0.145 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site