lkml.org 
[lkml]   [2015]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] x86/asm/entry/64: Tidy up JZ insns after TESTs
On 04/27/2015 06:21 AM, Denys Vlasenko wrote:
>
> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
> index e952f6b..8f8b22a 100644
> --- a/arch/x86/kernel/entry_64.S
> +++ b/arch/x86/kernel/entry_64.S
> @@ -666,7 +666,7 @@ END(irq_entries_start)
> leaq -RBP(%rsp),%rdi /* arg1 for \func (pointer to pt_regs) */
>
> testl $3, CS-RBP(%rsp)
> - je 1f
> + jz 1f
> SWAPGS
> 1:

Please don't insert tabs between opcode and operand unless that is the
style of the surrounding code.

Otherwise this patchset looks good.

-hpa



\
 
 \ /
  Last update: 2015-04-28 00:41    [W:0.092 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site