Messages in this thread | | | From | Alexandre Courbot <> | Date | Mon, 27 Apr 2015 12:58:17 +0900 | Subject | Re: [PATCH 00/23] gpio: sysfs: fixes and clean ups |
| |
On Wed, Apr 22, 2015 at 12:42 AM, Johan Hovold <johan@kernel.org> wrote: > These patches fix a number of issues with the gpio sysfs interface, > including > > - fix memory leaks and crashes on device hotplug > - straighten out the convoluted locking > - reduce sysfs-interface latencies through more fine-grained locking > - more clearly separate the sysfs-interface implementation from gpiolib > core > > The first patch is marked for stable and could go into 4.1. > > Unfortunately we can't just kill the gpio sysfs interface, but these > patches will make it more manageable and should allow us to implement a > new user-space interface while maintaining the old one (for a while at > least) without losing our sanity. > > Note that there is still a race between chip remove and gpiod_request (and > therefore sysfs export), which needs to be fixed separately (for instance as > part of a generic solution to chip hotplugging).
Thanks a lot for this great series. To my embarrassment I could not find anything big to say about it. It simply fixes some of the biggest issues with the sysfs interface and makes things much more maintainable.
I made a few minor comments, but globally I like this very much.
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
| |