Messages in this thread | | | Subject | Re: [RFC PATCH] power: axp288_charger: axp288 charger driver | From | Paul Bolle <> | Date | Sat, 25 Apr 2015 11:09:17 +0200 |
| |
Just a nit: a license mismatch.
On Fri, 2015-04-24 at 22:36 +0530, Ramakrishna Pallala wrote: > diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig > index 4091fb0..c7d7e8b 100644 > --- a/drivers/power/Kconfig > +++ b/drivers/power/Kconfig > --- /dev/null > +++ b/drivers/power/axp288_charger.c
> + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; version 2 of the License. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details.
This states the license is GPL v2.
> +MODULE_LICENSE("GPL");
And, according to include/linux/module.h, this states the license is GPL v2 or later. So I think either the license comment or the ident used in the MODULE_LICENSE() macro should be changed.
Paul Bolle
| |