lkml.org 
[lkml]   [2015]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] block: remove BIO_EOPNOTSUPP
Date
Christoph Hellwig <hch@lst.de> writes:

> Since the big barrier rewrite/removal in 2007 we never fail FLUSH or
> FUA requests, which means we can remove the magic BIO_EOPNOTSUPP flag
> to help propagating those to the buffer_head layer.

I had a look through the kernel, checking for places where maybe we were
relying on an EOPNOTSUPP from REQ_DISCARD, just to ensure you weren't
pulling out an error path that could still be used. I think everything
checks out.

> diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
> index 992ef58..c2ee937 100644
> --- a/include/linux/blk_types.h
> +++ b/include/linux/blk_types.h
> @@ -118,7 +118,6 @@ struct bio {
> #define BIO_CLONED 4 /* doesn't own data */
> #define BIO_BOUNCED 5 /* bio is a bounce bio */
> #define BIO_USER_MAPPED 6 /* contains user pages */
> -#define BIO_EOPNOTSUPP 7 /* not supported */
> #define BIO_NULL_MAPPED 8 /* contains invalid user pages */
> #define BIO_QUIET 9 /* Make BIO Quiet */
> #define BIO_SNAP_STABLE 10 /* bio data must be snapshotted during write */

Should we leave a hole in the numbering scheme?

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>


\
 
 \ /
  Last update: 2015-04-24 22:41    [W:0.160 / U:1.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site