lkml.org 
[lkml]   [2015]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next,v2,1/1] hv_netvsc: introduce netif-msg into netvsc module
From
Date
On Fri, 2015-04-24 at 11:34 -0700, sixiao@microsoft.com wrote:
> From: Simon Xiao <sixiao@microsoft.com>
>
> 1. Introduce netif-msg to netvsc to control debug logging output
> and keep msg_enable in netvsc_device_context so that it is
> kept persistently.
> 2. Only call dump_rndis_message() when NETIF_MSG_RX_ERR or above
> is specified in netvsc module debug param.
> In non-debug mode, in current code, dump_rndis_message() will not
> dump anything but it still initialize some local variables and
> process the switch logic which is unnecessary, especially in
> high network throughput situation.

[]

> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
[]
> @@ -888,6 +891,11 @@ static int netvsc_probe(struct hv_device *dev,
>
> net_device_ctx = netdev_priv(net);
> net_device_ctx->device_ctx = dev;
> + net_device_ctx->msg_enable = netif_msg_init(debug, default_msg);
> + if (netif_msg_probe(net_device_ctx))
> + netdev_dbg(net, "netvsc msg_enable: %d",
> + net_device_ctx->msg_enable);

Please use newlines to terminate formats.

It helps prevent log content interleaving when multiple processes
are emitting output at the same time.

This could be shortened to use netif_<level> like:

netif_dbg(net_device_ctx, probe, net, "netvsc_msg_enable: %d\n",
net_device_ctx->msg_enable);





\
 
 \ /
  Last update: 2015-04-24 22:41    [W:0.059 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site