Messages in this thread | | | Date | Fri, 24 Apr 2015 09:42:37 -0400 | From | "Frank Ch. Eigler" <> | Subject | Re: [PATCH] Kbuild: Add an option to enable GCC VTA |
| |
Hi, Josh -
On Fri, Apr 24, 2015 at 08:40:02AM -0400, Josh Boyer wrote: > [...] > Frank, did you rebase this against some newer tree or something?
Yes; the lib/Kconfig.debug part didn't apply to current git.
> Curious why you sent it again.
At least as a patch-ping; the poor-debuginfo problems are reported to affect non-fedora users too.
> > +ifdef CONFIG_DEBUG_INFO_VTA > > +KBUILD_CFLAGS += $(call cc-option, -fvar-tracking-assignments) > > +else > > +KBUILD_CFLAGS += $(call cc-option, -fno-var-tracking-assignments) > > +endif > > + > > Is there a reason you moved this hunk under the DWARF4 options instead > of modifying it in-place like the original patch did?
Yes, this version appears a little safer, in the sense that without CONFIG_DEBUG_INFO, neither setting of CONFIG_DEBUG_INFO_VTA would affect the CFLAGS. (In fact, Jakub advises the positive polarity -fvar-tracking-assignments is redundant with -g, and the negative polarity one only provides codegen-bug-protection in the CONFIG_DEBUG_INFO case.)
- FChE
| |